Skip to content

Conversation

@gadomski
Copy link
Member

@gadomski gadomski commented Apr 26, 2023

Related Issue(s):

Description:

This is in DefaultStacIO ... other StacIOs could support writing to urls, if they want. cc @constantinius.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.8 milestone Apr 26, 2023
@gadomski gadomski requested a review from jsignell April 26, 2023 11:59
@gadomski gadomski self-assigned this Apr 26, 2023
This is in DefaultStacIO ... other StacIOs could support writing to urls, if
they want.
@gadomski gadomski force-pushed the issues/1106-saving-http-hrefs branch from e452c9c to 828301b Compare April 26, 2023 12:00
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one suggestion

@gadomski gadomski added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit d1fad69 Apr 26, 2023
@gadomski gadomski deleted the issues/1106-saving-http-hrefs branch April 26, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

save pulls in external catalogs

3 participants