Support multiple schema versions following changes in #1091

Author: jpolchlo

CHANGELOG.md

@@ -10,6 +10,7 @@
 - MGRS Extension ([#1088](https://github.com/stac-utils/pystac/pull/1088))
 - All HTTP requests are logged when level is set to `logging.DEBUG` ([#1096](https://github.com/stac-utils/pystac/pull/1096))
 - Updated raster extension to work with the item_assets extension's AssetDefinition objects ([#1110](https://github.com/stac-utils/pystac/pull/1110))
+- Classification extension ([#1093](https://github.com/stac-utils/pystac/pull/1093)), with support for adding classification information to item_assets' `AssetDefinition`s and raster's `RasterBand` objects.
 
 ### Changed
 

pystac/extensions/classification.py

@@ -10,6 +10,7 @@
     Iterable,
     List,
     Optional,
+    Pattern,
     TypeVar,
     Union,
     cast,
@@ -29,14 +30,20 @@
 
 T = TypeVar("T", pystac.Item, pystac.Asset, item_assets.AssetDefinition, RasterBand)
 
-SCHEMA_URI: str = "https://stac-extensions.github.io/classification/v1.0.0/schema.json"
-PREFIX: str = "classification:"
+SCHEMA_URI_PATTERN: str = (
+    "https://stac-extensions.github.io/classification/v{version}/schema.json"
+)
+DEFAULT_VERSION: str = "1.1.0"
+SUPPORTED_VERSIONS: List[str] = ["1.1.0", "1.0.0"]
 
 # Field names
+PREFIX: str = "classification:"
 BITFIELDS_PROP: str = PREFIX + "bitfields"
 CLASSES_PROP: str = PREFIX + "classes"
 RASTER_BANDS_PROP: str = "raster:bands"
 
+COLOR_HINT_PATTERN: Pattern[str] = re.compile("^([0-9A-Fa-f]{6})$")
+
 
 class Classification:
     """Represents a single category of a classification.
@@ -73,8 +80,7 @@ def apply(
         self.color_hint = color_hint
 
         if color_hint is not None:
-            color_hint_pattern = re.compile("^([0-9A-F]{6})$")
-            match = color_hint_pattern.match(color_hint)
+            match = COLOR_HINT_PATTERN.match(color_hint)
             assert (
                 color_hint is None or match is not None and match.group() == color_hint
             ), "Must format color hints as '^([0-9A-F]{6})$'"
@@ -164,8 +170,7 @@ def color_hint(self) -> Optional[str]:
     @color_hint.setter
     def color_hint(self, v: Optional[str]) -> None:
         if v is not None:
-            color_hint_pattern = re.compile("^([0-9A-F]{6})$")
-            match = color_hint_pattern.match(v)
+            match = COLOR_HINT_PATTERN.match(v)
             assert (
                 v is None or match is not None and match.group() == v
             ), "Must format color hints as '^([0-9A-F]{6})$'"
@@ -495,7 +500,11 @@ def _get_bitfields(self) -> Optional[List[Bitfield]]:
 
     @classmethod
     def get_schema_uri(cls) -> str:
-        return SCHEMA_URI
+        return SCHEMA_URI_PATTERN.format(version=DEFAULT_VERSION)
+
+    @classmethod
+    def get_schema_uris(cls) -> List[str]:
+        return [SCHEMA_URI_PATTERN.format(version=v) for v in SUPPORTED_VERSIONS]
 
     @classmethod
     def ext(cls, obj: T, add_if_missing: bool = False) -> ClassificationExtension[T]:
@@ -627,7 +636,7 @@ def bitfields(self, v: Optional[List[Bitfield]]) -> None:
 
 
 class ClassificationExtensionHooks(ExtensionHooks):
-    schema_uri: str = SCHEMA_URI
+    schema_uri: str = SCHEMA_URI_PATTERN.format(version=DEFAULT_VERSION)
     prev_extension_ids = {"classification"}
     stac_object_types = {pystac.STACObjectType.ITEM}
 

tests/extensions/test_classification.py

@@ -56,7 +56,12 @@ def test_stac_extensions(landsat_item: Item) -> None:
 
 
 def test_get_schema_uri(landsat_item: Item) -> None:
-    assert ClassificationExtension.get_schema_uri() in landsat_item.stac_extensions
+    assert any(
+        [
+            uri in landsat_item.stac_extensions
+            for uri in ClassificationExtension.get_schema_uris()
+        ]
+    )
 
 
 def test_ext_raises_if_item_does_not_conform(plain_item: Item) -> None:
@@ -78,7 +83,8 @@ def test_apply(plain_item: Item) -> None:
             )
         ]
     )
-    # plain_item.validate()  ## THIS FAILS
+
+    plain_item.validate()
     assert (
         ClassificationExtension.ext(plain_item).bitfields is not None
         and len(cast(List[Bitfield], ClassificationExtension.ext(plain_item).bitfields))