Improve tests

Author: jpolchlo

pystac/extensions/classification.py

@@ -159,7 +159,7 @@ def color_hint(self) -> Optional[str]:
         Returns:
             Optional[str]
         """
-        return self.properties.get("color_hint")
+        return self.properties.get("color-hint")
 
     @color_hint.setter
     def color_hint(self, v: Optional[str]) -> None:
@@ -169,9 +169,9 @@ def color_hint(self, v: Optional[str]) -> None:
             assert (
                 v is None or match is not None and match.group() == v
             ), "Must format color hints as '^([0-9A-F]{6})$'"
-            self.properties["color_hint"] = v
+            self.properties["color-hint"] = v
         else:
-            self.properties.pop("color_hint", None)
+            self.properties.pop("color-hint", None)
 
     def to_dict(self) -> Dict[str, Any]:
         """Returns the dictionary encoding of this class
@@ -181,11 +181,15 @@ def to_dict(self) -> Dict[str, Any]:
         """
         return self.properties
 
-    def __eq__(self, other):
-        return self.value == other.value and \
-            self.description == other.description and \
-            self.name == other.name and \
-            self.color_hint == other.color_hint
+    def __eq__(self, other: object) -> bool:
+        if not isinstance(other, Classification):
+            raise NotImplementedError
+        return (
+            self.value == other.value
+            and self.description == other.description
+            and self.name == other.name
+            and self.color_hint == other.color_hint
+        )
 
     def __repr__(self) -> str:
         return f"<Classification value={self.value} description={self.description}>"
@@ -381,7 +385,7 @@ def name(self, v: Optional[str]) -> None:
     def __repr__(self) -> str:
         return (
             f"<Bitfield offset={self.offset} length={self.length} "
-            "classes={self.classes}>"
+            f"classes={self.classes}>"
         )
 
     def to_dict(self) -> Dict[str, Any]: