Skip to content

fix(ssvsigner): linter and tests #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

fix(ssvsigner): linter and tests #2171

merged 2 commits into from
Apr 24, 2025

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Apr 23, 2025

#2028 has been merged with broken linter and tests, it likely happened in one of the latest commits. The reason we didn't notice this is that the ssvsigner subfolder has its own go.mod, so it's not covered by the CI checks (similarly to the e2e subfolder)

It would be really great to have linter & tests for the ssv-signer in CI but it might be tricky: golangci/golangci-lint#828

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.7%. Comparing base (47ea4bc) to head (f0f0414).
Report is 2 commits behind head on stage.

Files with missing lines Patch % Lines
cli/operator/node.go 0.0% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@y0sher y0sher merged commit 1065f78 into stage Apr 24, 2025
6 of 7 checks passed
@y0sher y0sher deleted the ssv-signer-fix-tests branch April 24, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants