Skip to content

Conversation

bennobuilder
Copy link

Closes #21

@bennobuilder bennobuilder marked this pull request as draft March 19, 2024 09:51
@bennobuilder bennobuilder marked this pull request as ready for review March 19, 2024 15:53
@bennobuilder
Copy link
Author

Testcase visualization

image
image
image
image
image
image

@cademirch
Copy link

Hi @sstadick - I was looking for this feature for my use case and found myself here, happy to help push this across the finish line, but am curious what you'd like to see here to merge this.

@sstadick
Copy link
Owner

Hi @cademirch! I'll go back and take a look at what's here this weekend, I don't remember what held this back the first time around. Do you just need the merge_with? Or some of the other stuff that was added as well?

@cademirch
Copy link

@sstadick No rush, thanks! I just need merge_with. For context, I am wanting to collect all of the overlapping intervals' values in the merged interval (unless this is possible already?).

@sstadick
Copy link
Owner

sstadick commented Sep 2, 2025

@cademirch @bennobuilder - finally read through all this, and it's great! I'm really sorry I missed this when it originally went up. I'm down to get it merged, it just needs the rebase conflicts merged.

I do have one question - for the merge_with I would kind of lean toward passing in the full Intervals to each instead of just the value in case that changes how a user does the merge, but I'm open to not doing that if there's some std lib precedent, or just a strong feeling from either of you on what's best with that particular fn signature.

@cademirch
Copy link

@sstadick great! I'm heading on vacation for a few days but can help with this when I'm back. As for passing the full interval vs value, I'm not sure how much it matters to my use case, but can look more when I'm back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge_overlaps loses values

3 participants