Changes made for Multiple Codegen #8
Conversation
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
Please delete the .DS_Store file from the repo and add it to .gitignore.
Also read the env var once and use it from the app.config
servicex_codegen/post_operation.py
Outdated
| # code gen transformer returns the default transformer image mentioned in | ||
| # the config file | ||
| transformer_image = current_app.config.get("TRANSFORMER_SCIENCE_IMAGE") | ||
| transformer_image = os.environ.get('TRANSFORMER_SCIENCE_IMAGE') |
There was a problem hiding this comment.
I would stick with one place that reads the environment var and puts it in the app config and then use app config here.
It will surprise someone later that the property in app.config isn't used here!
There was a problem hiding this comment.
I have removed the DS store and added the .gitignore, for the app config thing, for some reason it does not work as intended, we have triend over 10 alpha version tests to check this thing, os.environ.get works but current_app.config does not, further, in the init.py the equation has to be there to set the value from os.environ to the app config. Although it does not make sense from a code perspective to do this, it does not work otherwise
Code generators return language and science command
No description provided.