Add support for RSA SHA-2 public key algorithms #1177
Conversation
Rob-Hague
requested review from
WojciechNagorski and
drieseng
as code owners
|
@Rob-Hague I've pushed some changes to this PR. Can you review this? |
|
Thanks! I should have paid more attention to |
|
Thanks to removing PubkeyAcceptedAlgorithms from the config file we know that SSH.NET supports the latest version of OpenSSH without any hack (configuration). |
| /// Initializes a new instance of the <see cref="RsaDigitalSignature"/> class with the SHA-1 hash algorithm. | ||
| /// </summary> | ||
| /// <param name="rsaKey">The RSA key.</param> | ||
| public RsaDigitalSignature(RsaKey rsaKey) |
There was a problem hiding this comment.
how about adding [Obsolete("Comment")] and using always new constructor?
There was a problem hiding this comment.
I do not think it is necessary here
(but I don't mind)
|
It looks that everything is ready. I have to look over |
There was a problem hiding this comment.
Great work! Without you, we definitely wouldn't have rsa-sha-256 and rsa-sha-512 in this release. I'm merging this PR as is, but I will change the approach for IHostAlgorithmsProvide in the next PR. I've done many tests and experiments and it turned out that this was not the best approach.
|
Awesome. Your approach to |
|
When are you thinking to release? |
|
This week or next. |
|
@WojciechNagorski I am very grateful about this release :) It will help us a lot. Thank you! |
|
I tested it with the current development branch. But it is still not working for me. Over console window with ssh root@xyz it works fine.
Exception in ClientAuthentication.cs: Do you have any Idea? Thank you all! |
|
Can you step through What are the algorithms returned in edit: your key path also says ed25519. Are you sure this is related to rsa? |
|
Thank you ... sure
|
|
Your key is an ed25519 so I would suggest that it is not related to this PR. Would you mind opening another issue and pasting the result of ssh console command with "-v" (verbose) argument? |
Do you have any update to share on the delivery timeline please ? |
|
@YohanSciubukgian If it doesn't work out this week, I'll do it at the beginning of next week, regardless of the thing I'm waiting for. |
5 participants
See #1174 and RFC 8332 for details.
closes #1174
closes #1145
closes #1116
closes #1105
closes #956
closes #825
It may also close the following:
#1141
#1025
#1003
#858
#845