This repository was archived by the owner on Sep 11, 2020. It is now read-only.
utils/fs: Fix O_CREATE flag check in OpenFile #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, how you found the issue? this requires a test @smola |
|
I just reviewed the code changes from rc1 to rc2, and it caught my eyes. |
|
Tests added. Thanks @jinroh! |
smola
approved these changes
Nov 7, 2016
alcortesm
approved these changes
Nov 7, 2016
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* utils/fs: Fix O_CREATE flag check in OpenFile * utils/fs/os: test that Open does not create dirs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag checking is using a
|instead of&againstos.O_CREATE.