Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

CheckClose should be used with named returns #791

@jfontan

Description

@jfontan

If defer CheckClose(closer, &err) is used without named returns any close error is lost. This happens here:

https://github.com/src-d/go-git/blob/master/plumbing/format/packfile/common.go#L50

Check if there are any other place where CheckClose is not used with a named return.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions