Add missing features to renderForTest Api #1427
Merged
+655
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Zikstar
changed the title
Zikstar
force-pushed
the
isaaco/update_render_for_test
branch
from
c6a5c4a to
0150852
Compare
steve-the-edwards
approved these changes
Nov 4, 2025
Contributor
steve-the-edwards
left a comment
steve-the-edwards
left a comment
There was a problem hiding this comment.
I think we could improve the snapshot testing part of WorkflowTurbineTest as we could check the values inside the snapshot. Also i'm confused by one of the tests, but otherwise LGTM!
workflow-testing/src/test/java/com/squareup/workflow1/testing/WorkflowTurbineTest.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
Sure! PR is now updated with your comments address @steve-the-edwards |
Zikstar
force-pushed
the
isaaco/update_render_for_test
branch
from
f38cf9a to
a9ffe88
Compare
Zikstar
force-pushed
the
isaaco/update_render_for_test
branch
from
a9ffe88 to
cb733ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #1152 : The
launchForTestingapis are deprecated and there's some extra work to bring all the missing features fromlaunchForTestingto therenderForTestapi. This PR addresses addresses the first two of four left over work streams to fully deprecate the old api namely:It also adds the functionality for
which were important parts of the usage of the old api.
I still plan to do some work use the Adapter/Facade pattern to make
launchForTestinguserenderForTestunder the hood in order to achieve goal 3, but that would be a separate PR.