Collect renderings on context specified in WorkflowLayout.take #1424
+10
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
steve-the-edwards
force-pushed
the
sedwards/update-take-dispatcher-rules
branch
from
e370e97 to
86bc859
Compare
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
tcmulcahy
approved these changes
Nov 11, 2025
| "Collection dispatch should happen on the lifecycle's dispatcher." | ||
| withContext(collectionContext) { | ||
| require(Looper.myLooper() == Looper.getMainLooper()) { | ||
| "Collection dispatch should happen on the main thread!" |
| * @param [collectionContext] additional [CoroutineContext] we want for the coroutine that is | ||
| * launched to collect the renderings. This should not override the [CoroutineDispatcher][kotlinx.coroutines.CoroutineDispatcher] | ||
| * but may include some other instrumentation elements. | ||
| * launched to collect the renderings, can include a different dispatcher - but it should be |
Collaborator
There was a problem hiding this comment.
Suggested wording: "can include a different dispatcher - but we verify that it's a main thread dispatcher" And maybe explain why this restriction exists (naively I thought all of this stuff was immutable so it'd be safe to access them from any thread)
| unoriginal.show(BScreen(), env) | ||
| } | ||
|
|
||
| @Test fun usesLifecycleDispatcher() { |
Collaborator
There was a problem hiding this comment.
Do we have any test coverage now? If you took out the withContext statement and just ran the block directly would any test fail? (If not, I think we should test that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.