Clean up Test Specification in our Github Actions #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
steve-the-edwards
force-pushed
the
sedwards/unit-tests-action-update
branch
4 times, most recently
from
f1237e8 to
c762f60
Compare
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: specified-upload | ||
| name: ${{inputs.failure-upload-name}} |
Contributor
Author
There was a problem hiding this comment.
@zach-klippenstein I also fixed test report upload on failure - so you can download the typical .html report and see the reasons for all your different test failures in CI.
| restore-cache-key: build-logic | ||
| write-cache-key: main-build-artifacts | ||
| failure-path-upload: '**/build/reports/tests/*[tT]est' | ||
| failure-upload-name: 'unit-tests-report' |
Contributor
Author
There was a problem hiding this comment.
Here is where we specify failure-path-upload (what to upload when there is a failure on the job).
steve-the-edwards
changed the title
zach-klippenstein
approved these changes
Aug 28, 2025
steve-the-edwards
force-pushed
the
sedwards/unit-tests-action-update
branch
from
c762f60 to
d1d9b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
jvmTestpreviously for the tests where we specify the runtime via the environment arg, but thejvmTesttask is only for KMP modules. Those KMP modules (namelyworkflow-runtime) already accounted for multiple runtimes usingBurst, so we were just running the same tests multiple times (it was not even using theJvmTestRuntimeConfigToolsto pull the arg).We should be running the regular java/android
testtask with the runtime specification, then the arg will be picked up.Also some other fixes for the proper targets - e.g.,
iosSimulatorArm64andjsBrowserTest.AND fixes the
failure-path-uploadusage so that we upload the test report successfully (the html one) when there is a failure (whether JVM or Android tests). (I've tested this when the tests were failing that I fixed).I had to modify two tests to check for particular runtime configs that are incompatible with the test structure, but everything else is working. yay!