DRAIN_EXCLUSIVE_ACTIONS implementation #1355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/dea-2-for-real
branch
4 times, most recently
from
b276a5b to
eefc6d8
Compare
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
There was a problem hiding this comment.
I don't understand the interaction between conflation and drainExclusive. It looks like we run the drainExclusive loop first, then render, then conflate, drainExclusive, and render, etc. Wouldn't we want to continuously interleave drainExclusive and conflation passes? Or is that what we're doing and I just can't read code?
| ): Unit = Unit | ||
|
|
||
| public sealed interface RuntimeLoopOutcome | ||
| public sealed interface RuntimeUpdate |
There was a problem hiding this comment.
At the risk of over-optimizing, this could be a value class to avoid allocating RenderingProduced objects every pass even when they're ignored.
| } | ||
|
|
||
| @Test | ||
| fun `for_drain_exclusive_and_render_only_when_state_changes_we_handle_multiple_actions_in_one_render_but_we_do_pass_rendering_if_state_changed_earlier`() { |
There was a problem hiding this comment.
Nit: You shouldn't need the backticks here, you're not using spaces or other illegal characters.
steve-the-edwards
force-pushed
the
sedwards/dea-2-for-real
branch
from
e6b2344 to
1551901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to get the next action that is mutually exclusive to the dirty nodes. Then we can apply as many of those actions as possible.
Add tests for this as well and ensure existing tests can run with this runtime config on.