This repository was archived by the owner on Feb 5, 2021. It is now read-only.
Rename showRendering to WorkflowRendering and make it not an extension function. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
reviewed
May 28, 2020
| @@ -98,7 +98,7 @@ class PreviewComposeWorkflowTest { | |||
| Column { | |||
| Text(props.first) | |||
| Semantics(container = true, mergeAllDescendants = true) { | |||
| environment.showRendering(rendering = props.second) | |||
| WorkflowRendering(props.second, environment) | |||
There was a problem hiding this comment.
I really like this. The noun v verb discussion resonated.
rjrjr
approved these changes
May 28, 2020
…n function. Fixes #21, see that issue for rationale.
zach-klippenstein
force-pushed
the
zachklipp/rename-showrendering
branch
from
e39b9ff to
49228bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21, see that issue for rationale.