This repository was archived by the owner on Feb 5, 2021. It is now read-only.
Renames ComposeViewFactoryRoot to CompositionRoot and decouples the implementation. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+49
to
+42
| internal fun ViewRegistry.mapFactories( | ||
| transform: (ViewFactory<*>) -> ViewFactory<*> | ||
| ): ViewRegistry = object : ViewRegistry { | ||
| override val keys: Set<KClass<*>> get() = [email protected] | ||
|
|
||
| override fun <RenderingT : Any> getFactoryFor( | ||
| renderingType: KClass<out RenderingT> | ||
| ): ViewFactory<RenderingT> { | ||
| val transformedFactory = transform([email protected](renderingType)) | ||
| check(transformedFactory.type == renderingType) { | ||
| "Expected transform to return a ViewFactory that is compatible with $renderingType, " + | ||
| "but got one with type ${transformedFactory.type}" | ||
| } | ||
| @Suppress("UNCHECKED_CAST") | ||
| return transformedFactory as ViewFactory<RenderingT> | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the key to the decoupled implementation. This technique can be used to do other stuff too, like e.g. apply a modifier to each ViewFactory's view.
There was a problem hiding this comment.
I think I've already had a few use cases for this, should we move it to the main repo?
zach-klippenstein
force-pushed
the
zachklipp/even-better-root
branch
from
f94ee4c to
497a7e3
Compare
|
Failed test looks like a weird github issue – same shard appears twice, passed the second time. |
rjrjr
approved these changes
May 28, 2020
…mplementation. The root is now applied via a `ViewRegistry` wrapper that wraps individual factories to apply the root, instead of having this logic hard-coded inside `ComposeViewFactory`. This approach is more flexible in general (could be used to do other tricks), and decouples the rooting feature from the rest of the code.
zach-klippenstein
force-pushed
the
zachklipp/even-better-root
branch
from
497a7e3 to
ea57ae0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root is now applied via a
ViewRegistrywrapper that wraps individual factoriesto apply the root, instead of having this logic hard-coded inside
ComposeViewFactory.This approach is more flexible in general (could be used to do other tricks), and decouples
the rooting feature from the rest of the code.