-
Notifications
You must be signed in to change notification settings - Fork 70
Release v3.49.0 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.49.0 #99
Conversation
|
i don't fully understand this one: one of our test scripts recently stopped working with the same error and i disabled it because that test had always worked in the past and i assumed that the browsers had simply decided that it no longer works that way. i will look into this ASAP and hope to have a resolution for you today. |
|
|
|
This turns out to be a build problem - accessing makefile vars before an imported file sets them. i'll have a fix to you shortly. |
|
My sincere apologies for this hiccup. The current tip of the 3.49 branch has the fix for this (bug introduced via build refactoring): https://sqlite.org/src/timeline?r=branch-3.49 |
|
Thank you for that. It turns out that that problem also hit us a few versions ago for the same reason - build refactoring changed the order of makefile var decls and use. The build rules now check for this bug so they'll break loudly if i make that mistake again. |
|
@tomayac Hi, the patch seems not to work for me. I just updated to 3.49.0-build1 hook.js:608 ../../node_modules/@sqlite.org/sqlite-wasm/sqlite-wasm/jswasm/sqlite3-worker1-bundler-friendly.mjs |
|
Duh, of course top-level |
|
If you'd like to patch it now, that file's whole content, minus the docs, is: import {default as sqlite3InitModule} from './sqlite3-bundler-friendly.mjs';
sqlite3InitModule().then(sqlite3 => sqlite3.initWorker1API());We will probably be doing a 3.49.1 patch release late this week or early next, primarily for build-related tweaks, and this fix is in that version. |
|
Ah, nice. Published as build3 then. |
I'm trying to release
v3.49.0, but it fails:sqlite3-worker1-bundler-friendly.mjs:44Uncaught TypeError: Failed to execute 'importScripts' on 'WorkerGlobalScope': Module scripts don't support importScripts().This diff is the problem, @sgbeal.