Test SQLiteStatement.executeUpdateDelete() #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi brodyspark, We use this test suite to verify support from platform version 2.1-4.1 currently, running across different emulators. Due to the pull requests you've made, not all code is applicable across versions (e.g., Cursor.getType(...) was added in API 11). These tests would then cause build failures for lower versions that do not support that. While we appreciate the effort, we are going to hold off on merging the tests for now. Thanks! |
|
Hi brodyspark, Yes, you are correct - I will merge in #2, thanks for pointing this out! :-) |
developernotes
added a commit
that referenced
this pull request
Jan 3, 2013
Test SQLiteStatement.executeUpdateDelete()
Happy to hear, Chris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for android-database-sqlcipher pull request 81.