Skip to content

Implement ALTER TYPE SET SCHEMA #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2023
Merged

Implement ALTER TYPE SET SCHEMA #2027

merged 1 commit into from
Feb 23, 2023

Conversation

linux2647
Copy link
Contributor

Problem

Altering the schema for a given type is not reflected in generated code.

For example,

ALTER TYPE event SET SCHEMA new;

results in

type Event string

when it should be

type NewEvent string

Solution

Implement ALTER TYPE ... SET SCHEMA.

@linux2647
Copy link
Contributor Author

@kyleconroy Is there anything additional you need to review this PR?

@kyleconroy kyleconroy merged commit 8d082e4 into sqlc-dev:main Feb 23, 2023
@monkey-mas monkey-mas mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linux2647 @kyleconroy