attempt to fix foundational issue in stubs #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeek
force-pushed
the
fix_queryable_attribute
branch
2 times, most recently
from
146cade to
a908a42
Compare
|
the changes look ok. I can move them into #237 while targeting 1_4 and not another branch |
|
I thought maybe we can put "Any" at the base of QueryableAttribute , with these changes, then release, so that we can incrementally get this out. The mypy plugin changes I am hoping can be released without needing these stub changes at all, so that we can first see if they break anything on their own. mypy plugins are total dark magic |
|
In case it's needed releasing the stubs is very easy and we can do that multiple times a day without much trouble |
zzzeek
force-pushed
the
fix_queryable_attribute
branch
2 times, most recently
from
8ef2f7a to
b4ba6c9
Compare
zzzeek
force-pushed
the
fix_queryable_attribute
branch
from
b4ba6c9 to
7eb78de
Compare
|
let's merge this then I'll rebase the other change to see if there is anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the second revision of stubs, way in the beginning, if I'm reading correctly this commit: b7f469c, the basemost class of QueryableAttribute got lost. Since then, Mapped and QueryableAttribute have been treated as Any. All the revs of the plugin, the stubs, etc. have been based off this erroneous assumption. It's likely too late to change it
as it would introduce a lot of new risk. however, let's put
up a patch that's passing for the SQLAlchemy side, with some
mypy plugin changes on that end (yikes), then see if we can
get this side working, then look at what we have.
Description
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!