Skip to content

MemoizedHasCacheKey import path is wrong #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mehdigmira opened this issue Oct 9, 2022 · 0 comments · Fixed by #237
Closed

MemoizedHasCacheKey import path is wrong #236

mehdigmira opened this issue Oct 9, 2022 · 0 comments · Fixed by #237
Labels
bug Something isn't working

Comments

@mehdigmira
Copy link
Contributor

MemoizedHasCacheKey is imported from sql.base while it is defined in sql.traversals.

I suspect this today (silently) break some stuff.
@mehdigmira mehdigmira added the requires triage New issue that requires categorization label Oct 9, 2022
@mehdigmira mehdigmira mentioned this issue Oct 9, 2022
Merged
@CaselIT CaselIT added bug Something isn't working and removed requires triage New issue that requires categorization labels Jan 16, 2023
sqlalchemy-bot pushed a commit to sqlalchemy/sqlalchemy that referenced this issue Jan 18, 2023
@zzzeek
mypy plugin fixes
0e2b3aa 
Adjustments made to the mypy plugin to accommodate for some potential
changes being made for issue #236 sqlalchemy2-stubs when using SQLAlchemy
1.4. These changes are being kept in sync within SQLAlchemy 2.0.
The changes are also backwards compatible with older versions of
sqlalchemy2-stubs.

Fixed crash in mypy plugin which could occur on both 1.4 and 2.0 versions
if a decorator for the :func:`_orm.registry.mapped` decorator were used
that was referenced in an expression with more than two components (e.g.
``@Backend.mapper_registry.mapped``). This scenario is now ignored; when
using the plugin, the decorator expression needs to be two components (i.e.
``@reg.mapped``).

References: sqlalchemy/sqlalchemy2-stubs#236
Fixes: #9102
Change-Id: Ieb1bf7bf8184645bcd43253e57f1c267b2640537
sqlalchemy-bot pushed a commit to sqlalchemy/sqlalchemy that referenced this issue Jan 18, 2023
@zzzeek
mypy plugin fixes
2a53f70 
Adjustments made to the mypy plugin to accommodate for some potential
changes being made for issue #236 sqlalchemy2-stubs when using SQLAlchemy
1.4. These changes are being kept in sync within SQLAlchemy 2.0.
The changes are also backwards compatible with older versions of
sqlalchemy2-stubs.

Fixed crash in mypy plugin which could occur on both 1.4 and 2.0 versions
if a decorator for the :func:`_orm.registry.mapped` decorator were used
that was referenced in an expression with more than two components (e.g.
``@Backend.mapper_registry.mapped``). This scenario is now ignored; when
using the plugin, the decorator expression needs to be two components (i.e.
``@reg.mapped``).

References: sqlalchemy/sqlalchemy2-stubs#236
Fixes: #9102
Change-Id: Ieb1bf7bf8184645bcd43253e57f1c267b2640537
(cherry picked from commit cf64582f61b15716228302f669322d7efa1003c1)
(cherry picked from commit 36285760238314f70eed4532ca2c2c0c2d684609)
zzzeek added a commit that referenced this issue Jan 18, 2023
@zzzeek
attempt to fix foundational issue in stubs
8ef2f7a 
Fixes: #236
zzzeek added a commit that referenced this issue Jan 18, 2023
@zzzeek
attempt to fix foundational issue in stubs
b4ba6c9 
Fixes: #236
zzzeek added a commit that referenced this issue Jan 18, 2023
@zzzeek
attempt to fix foundational issue in stubs
7eb78de 
Fixes: #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix memoizedhascache mehdigmira/sqlalchemy2-stubs
2 participants
@mehdigmira @CaselIT