Skip to content

Improve performance of getGenericMapResponse #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Improve performance of getGenericMapResponse #2873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ...enapi-starter-common/src/main/java/org/springdoc/core/service/GenericResponseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,14 @@ public class GenericResponseService implements ApplicationContextAware {
private final Lock reentrantLock = new ReentrantLock();

/**
* The Context.
* The constant LOGGER.
*/
private ApplicationContext applicationContext;
private static final Logger LOGGER = LoggerFactory.getLogger(GenericResponseService.class);

/**
* The constant LOGGER.
* A list of all beans annotated with {@code @ControllerAdvice}
*/
private static final Logger LOGGER = LoggerFactory.getLogger(GenericResponseService.class);
private List<ControllerAdviceBean> controllerAdviceBeans;

/**
* Instantiates a new Generic response builder.
Expand Down Expand Up @@ -702,8 +702,6 @@ private Map<String, ApiResponse> getGenericMapResponse(HandlerMethod handlerMeth
.map(ControllerAdviceInfo::getApiResponseMap)
.collect(LinkedHashMap::new, Map::putAll, Map::putAll);

List<ControllerAdviceBean> controllerAdviceBeans = ControllerAdviceBean.findAnnotatedBeans(applicationContext);

List<ControllerAdviceInfo> controllerAdviceInfosNotInThisBean = controllerAdviceInfos.stream()
.filter(controllerAdviceInfo ->
getControllerAdviceBean(controllerAdviceBeans, controllerAdviceInfo.getControllerAdvice())
Expand Down Expand Up @@ -834,6 +832,6 @@ private boolean isGlobalException(Class<?> exceptionClass) {

@Override
public void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
this.applicationContext = applicationContext;
controllerAdviceBeans = ControllerAdviceBean.findAnnotatedBeans(applicationContext);
}
}