Skip to content

Fixed skip validation in handleResponse #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

riviar
Copy link
Contributor

@riviar riviar commented May 13, 2020

Changed skip validation check in
AbstractWsSecurityInterceptor#handleResponse to look for optional
security header in response, instead of request

Changed skip validation check in
AbstractWsSecurityInterceptor#handleResponse to look for optional
security header in response, instead of request
@riviar
Copy link
Contributor Author

riviar commented May 13, 2020

By some odd test behaviour I have found that, when handling response, skipValidationIfNoHeaderPresent check looks for security header in request, instead of response. Which is likely an unintended behaviour. This small fix changes the check to verify actual message being handled.

@riviar riviar marked this pull request as ready for review May 13, 2020 16:25
@gregturn gregturn closed this in 8813aba Dec 1, 2020
@gregturn gregturn self-assigned this Dec 1, 2020
@gregturn gregturn added this to the 3.1.0-M1 milestone Dec 1, 2020
@gregturn
Copy link
Contributor

gregturn commented Dec 1, 2020

Thanks @riviar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants