Skip to content

Better conversion from ByteArrayOutputStream to String. #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Better conversion from ByteArrayOutputStream to String. #1324

wants to merge 1 commit into from

Conversation

hduelme
Copy link
Contributor

@hduelme hduelme commented Jan 25, 2023

Converting from an ByteArrayOutputStream to String by using new String(output.toByteArray()) creates an unnecessary copy of the data. So toString() should be used instead. Also it is easier to read.

@gregturn gregturn changed the title better conversion from ByteArrayOutputStream to String Better conversion from ByteArrayOutputStream to String. Feb 6, 2023
@gregturn gregturn self-assigned this Feb 6, 2023
@gregturn gregturn added the type: enhancement A general enhancement label Feb 6, 2023
@gregturn gregturn added this to the 4.0.2 milestone Feb 6, 2023
@gregturn gregturn closed this in 1b6fb7d Feb 6, 2023
@markreesmoj markreesmoj mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregturn gregturn

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hduelme @gregturn