HttpComponentsMessageSender inintuitive constructor [SWS-835]

[gregturn]

Erik van Konijnenburg opened SWS-835 and commented

HttpComponentsMessageSender has two constructors, with and without HttpClient, and the one with HttpClient omits adding a SoapRemoveHeaderInterceptor.

This breaks in org.apache.http.protocol.RequestContent with
new ProtocolException("Content-Length header already present"),
but only in some containers (oc4j) and not in others (jetty, eclipe); this makes the issue hard to debug.

Adding a note to the javadoc would help the developer pick the proper constructor to avoid this issue.

git pull request coming up.

---

Affects: 2.1.3

Issue Links:

• HttpComponentsMessageSender: Use the PoolingClientConnectionManager instead of the deprecated ThreadSafeClientConnManager [SWS-838] #912 HttpComponentsMessageSender: Use the PoolingClientConnectionManager instead of the deprecated ThreadSafeClientConnManager

Referenced from: commits d2f4ba5

[gregturn]

Arjen Poutsma commented

Git pull request at #5