SimpleNamespaceContext.removeBinding() does not clean up all references [SWS-819]

[gregturn]

Timo Thomas opened SWS-819 and commented

In SimpleNamespaceContext.removeBinding() the first line should be changed to

String namespaceUri = prefixToNamespaceUri.remove(prefix);

Otherwise the internal map prefixToNamespaceUri still contains the prefix, and hasBinding(String prefix) behaves incorrectly.

This is error is critical, as under certain circumstances XML schema validation fails. If necessary I can provide an example.

---

Affects: 1.5.9, 2.1.2

Referenced from: commits 041229b, 88b4625

[gregturn]

Arjen Poutsma commented

Fixed! Thanks for spotting this.

[gregturn]

Timo Thomas commented

Your welcome. Took me a whole day to track this down. Didn't expect an error at this level, quite surprising that this one could live for so long.

Please also fix for 1.5.10 as this is the version we're currently using. Thanks.

[gregturn]

Arjen Poutsma commented

I've fixed this in the 1.5 branch in SVN, but I am afraid there won't be a 1.5.11 that contains it, as it is not supported anymore.