WebServiceTemple -> add logRequest method analogue to existing logResponse [SWS-803]

[gregturn]

Tamás Láng opened SWS-803 and commented

Hi!

I want to log the webservice requests and responses in the application I'm currently working on.
My approach would be to use AOP and watch the methods you use in your code for logging.
I found "logResponse(MessageContext messageContext)throws IOException" method in the WebServiceTemplate, for that I could create a pointcut.

But I would need something for the request logging as well and now the request logging currently located in the method:
sendRequest(WebServiceConnection connection, WebServiceMessage request) throws IOException
which is also good, just It would be good to separate the logging part imho.
So you could add a similar method to logResponse.

Additional question is that I found that there are so called TracingLogger's creatd with logFactory. Maybe instead of thinking in AOP I could use them with defining my own somehow?

What do you think?

THanks!

---

Affects: 2.1.1

[gregturn]

Arjen Poutsma commented

Instead of using AOP, I think it's a lot easier to just use a org.springframework.ws.client.support.interceptor.ClientInterceptor for logging request and response, and register that with the template. Something like:

public class LoggingClientInterceptor implements ClientInterceptor {

    private static final Log logger = LogFactory.getLog(LoggingClientInterceptor.class);

    public boolean handleRequest(MessageContext messageContext) throws WebServiceClientException {
        logger.debug("Request: " + messageContext.getRequest());
        return true;
    }

    public boolean handleResponse(MessageContext messageContext) throws WebServiceClientException {
        logger.debug("Response :" + messageContext.getResponse());
        return true;
    }

    public boolean handleFault(MessageContext messageContext) throws WebServiceClientException {
        logger.debug("Fault:" + messageContext.getResponse());
        return true;
    }
}