SoapFaultMappingExceptionResolver not handling exception [SWS-777]

[gregturn]

Gordon Dickens opened SWS-777 and commented

Given the following configuration:

<bean class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
    <property name="exceptionMappings">
        <value>
            org.springframework.dao.EmptyResultDataAccessException=CLIENT,Entity not found
        </value>
    </property>
    <property name="defaultFault" value="SERVER"/>
</bean>

The result in 2.0.5 is correct:

<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">
        <SOAP-ENV:Header/>
        <SOAP-ENV:Body>
            <SOAP-ENV:Fault>
                <faultcode>SOAP-ENV:Client</faultcode>
                <faultstring xml:lang="en">Entity not found</faultstring>
            </SOAP-ENV:Fault>
        </SOAP-ENV:Body>
    </SOAP-ENV:Envelope>

The result in 2.1.0.RC1 is INCORRECT:

<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">
    <SOAP-ENV:Header/>
    <SOAP-ENV:Body>
        <SOAP-ENV:Fault>
            <faultcode>SOAP-ENV:Server</faultcode>
            <faultstring xml:lang="en">Incorrect result size: expected 1, actual 0</faultstring>
        </SOAP-ENV:Fault>
    </SOAP-ENV:Body>
</SOAP-ENV:Envelope>

---

Affects: 2.1 RC1

Issue Links:

• Extending SoapFaultAnnotationExceptionResolver results in competing annotation resolvers with backwards order [SWS-793] #875 Extending SoapFaultAnnotationExceptionResolver results in competing annotation resolvers with backwards order
  ("is duplicated by")
• <sws:annotation-driven/> should register a SoapFaultAnnotationExceptionResolver [SWS-772] #857 sws:annotation-driven/ should register a SoapFaultAnnotationExceptionResolver

Referenced from: commits 504e6b7

[gregturn]

Arjen Poutsma commented

Hmm, that's strange. Do you also use <sws:annotation-driven>, by any chance? There were some changes to that in 2.1.

Also: does the EmptyResultDataAccessException have a @SoapFault annotation, perhaps?

[gregturn]

Arjen Poutsma commented

Added formatting.

[gregturn]

Gordon Dickens commented

Arjen,

Yes, I have configured ws:annotation-driven/

I am using the examples from the Enterprise Integration with Spring course that I am teaching this week. I use those to run through the upcoming versions of SWS, SI & SB to determine any api changes to share with the students.

Thanks,
Gordon Dickens

@gdickens
linkedin.com/in/gordondickens
Blog: technophile.gordondickens.com

[gregturn]

Arjen Poutsma commented

Gordon,

Can you elaborate which example(s) of the EI course show this problem? That makes it a bit easier to duplicate.

EDIT: never mind, I found it myself in the ws-2 lab of the course.

Thanks,

Arjen

[gregturn]

Arjen Poutsma commented

It seems like #857 was the culprit here. See my last comment on that issue for the reason.

For the ws-2 lab, it seems like adding an ordered property will fix it, like so:

<bean class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
    <property name="order" value="0"/>
    <property name="exceptionMappings">
        <value>
            org.springframework.dao.EmptyResultDataAccessException=CLIENT,Entity not found
        </value>
    </property>
    <property name="defaultFault" value="SERVER"/>
</bean>