SaxUtils leaks file handles, locks file on Windows [SWS-783]

[gregturn]

Kristian Rosenvold opened SWS-783 and commented

The method "createInputSource" in SaxUtils leaks the input stream in

InputSource inputSource = new InputSource(resource.getInputStream());

While this might be considered a small nuisance, it becomes a PITA on Windows, because the "SimpleXsdSchema" uses this method and therefore locks the "xsd" file in the file system, which is a pain when running "mvn clean install" because clean fails because the XSD/WSDL file is locked.

There are basically 4 non-test usages of this method that need to be reworked to avoid leaking file handles.

---

Affects: 2.1 GA

Attachments:

• Added_closeable_support_to_saxutils.patch (13.29 kB)
• Added_closeable_support_to_saxutils1-v2.patch (17.67 kB)

[gregturn]

Kristian Rosenvold commented

The enclosed patch adds a "CloseableInputSource" that can be properly closed.

The test-cases on spring-ws seem to be quite far from working on windows, so I am unable to run them.

I am unsure of how this should be tested (if necessary).

[gregturn]

Kristian Rosenvold commented

It's locking on the WSDL too. Update coming soon

[gregturn]

Kristian Rosenvold commented

And here's version 2 that does not lock the wsdl file either

[gregturn]

Arjen Poutsma commented

Thanks for work you put into those patches, but I cannot confirm the problem actually exists. According to the InputSource Javadoc, the underlying input stream should be closed as part of the parsing process:

[...] standard processing of both byte and character streams is to close them on as part of end-of-parse cleanup, so applications should not attempt to re-use such streams after they have been handed to a parser.

I did some further testing on this by putting a breakpoint on InputStread.close(), and it does get called as part of DocumentBuilder.parse(). All of this on MacOS X, using the standard Oracle JDK (1.7.0_04-b21).

Are you using the standard Oracle JDK Xerces parser, or perhaps using something else, like the IBM JDK or a different parser?

[gregturn]

Arjen Poutsma commented

Closing as invalid for now.

[gregturn]

roger pack commented

also possibly related: http://betterlogic.com/roger/2013/04/documentbuilder-file-handle-leak-windows

[gregturn]

Kristian Rosenvold commented

@roger "not really", since I've been running on java7 all along.