Request JMS correlation id field not used to set response message JMS correlation id [SWS-534]

[gregturn]

Gary Flood opened SWS-534 and commented

In JmsReceiverConnection.onSendBeforeWrite(...) the following code sets the response correlation id field :-

responseMessage.setJMSCorrelationID(requestMessage .getJMSMessageID());

There does not seem to be a check on the inbound request's correlation id as in the following code from JmsInvokerServiceExporter.createResponseMessage(.. .)

String correlation = request.getJMSCorrelationID();
if (correlation == null) {
correlation = request.getJMSMessageID();
}
response.setJMSCorrelationID(correlation);

The above logic has also been implemented in MessageListnenerAdapter and I am looking for the same behaviour in JmsReceiverConnection.onSendBeforeWrite(...).

This seems to be related to http://jira.springframework.org/browse/SPR-4647

---

Affects: 1.5.4

Reference URL: http://forum.springsource.org/showthread.php?p=247490#post247490

Referenced from: commits b80f3b0

1 votes, 0 watchers

[gregturn]

Arjen Poutsma commented

This is in accordance with the SOAP over JMS spec, see http://www.w3.org/TR/2009/CR-soapjms-20090604/#responder-transition

[gregturn]

123 commented

I am also facing the same problem.
I am using the oracle service bus to post the message to the request queue.
I am seeting the response correlation pattern as correlation id.
The spring web serivice picks up the message from the request queue and after procerssing it sends the response back to the response queue.But the message is not getting picked up from the response queue.
But when i use Message Id as the respose correlation pattern,the message is gettnig picked up from the response queue.
This means by default, the request message id is set to the response correlation id.
when correlation id pattern is used then the request correlation id must be copied to the response correlation id. This is the reason why the Oracle service bus is not able to identify the message and hence not getting picked up.
The condition check for

if (correlation id==null)
response.setCorrelationID(request,getMessageId)
else
response.setCorrelationID(request,getCorrelationID)

Please fix this bug .

[gregturn]

Arjen Poutsma commented

We might be able to make this a configurable feature, i.e. you can pick whether you want response messages to use the request's message id or correlation id.

[gregturn]

Gary Flood commented

I'm happy that the Spring source is correctly implementing the spec. Possibly having a configurable feature with the current behaviour being the default would be a decent compromise. We have been able to work around the issue such that the message id being used as the correlation id is acceptable for our solution.

[gregturn]

Arjen Poutsma commented

I've decided against making it an option, and went for an automatic fallback instead of explicit configuration, just like JmsInvokerServiceExporter.

[gregturn]

123 commented

Thanks for the help.
How should i use it now.Is there any separate updated jar file available having this option?

[gregturn]

Arjen Poutsma commented

SNapshots are available at http://static.springsource.org/spring-ws/sites/1.5/downloads/snapshots.html

[gregturn]

Arjen Poutsma commented

Closing old issues