log Exceptions in SoapFaultMappingExceptionResolver (like spring webmvc SimpleMappingExceptionResolver) [SWS-490]

[gregturn]

Nicholas Blair opened SWS-490 and commented

The SimpleMappingExceptionResolver class in the Spring Web MVC project allows you to specify a "warnLogCategory"; when exceptions are resolved, and "WARN" level is available for the logger in the specified category, the SimpleMappingExceptionResolver logs the exception.

The SoapFaultMappingExceptionResolver methods involved in resolving an exception are all marked final, preventing extension of this class in order to add similar logging behavior.

The SoapFaultMappingExceptionResolver works great in returning SOAP Faults to clients in the event of an exception in the underlying business code, however my endpoint's log file does not contain any record of the problem.

---

Affects: 1.5.6

Referenced from: commits 35f2e8e

[gregturn]

Nicholas Blair commented

AbstractEndpointExceptionResolver (resolveException) or AbstractSoapFaultDefinitionExceptionResolver (resolveExceptionInternal) appear to be the target for implementing this behavior.

If SimpleMappingExceptionResolver from Spring Web MVC is a guide, the latter choice (resolveExceptionInternal in AbstractSoapFaultDefinitionExceptionResolver) would be a similar location for the logging function.

[gregturn]

Nicholas Blair commented

I noticed that if you set the log level to DEBUG for the class org.springframework.ws.soap.server.SoapMessageDispatcher, you will get any Exceptions logged before they are converted to SOAP Faults for response (message is "Endpoint invocation resulted in exception - responding with Fault").

The undesirable side effect of this however is the other DEBUG logging in that class results in 2 log messages per web services request.

[gregturn]

Arjen Poutsma commented

Closing old issues