xml:lang="en" attribute in <faultstring> element is not compliant to SOAP/1.1 schema [SWS-485]

[gregturn]

Oleksandr Alesinskyy opened SWS-485 and commented

There is xml:lang="en" attribute in <faultstring> element although SOAP/1.1 schema doesn't provide it.
Yes, it may be suppressed if set faultStringOrReasonLocale property for all affected endpoints to null,
set empty language for each and every exception mapping in SoapFaultMappingExceptionResolver (BTW, it is not
very well documented how to do it), set to null faultStringOrReasonLocale for message dispatcher,
oh did I forget something?

Probably, it may as well be avoided by subclassing of each of above mentioned classes (and likely some others),
but then each developer need to use them.

See as well http://www.eviware.com/component/option,com_smf/Itemid,53/topic,1044.0

IMHO, or it should comply with schema by default, or, in the worst case, it should exist some global setting
"be compliant".

Kind regards,
Oleksandr

---

Affects: 1.5.1

Reference URL: http://forum.springframework.org/showthread.php?t=65135

Issue Links:

• CLONE -xml:lang="en" attribute in <faultstring> element is not compliant to SOAP/1.1 schema [SWS-487] #620 CLONE -xml:lang="en" attribute in <faultstring> element is not compliant to SOAP/1.1 schema
  ("is duplicated by")

Referenced from: commits cd05c54

[gregturn]

Arjen Poutsma commented

In fact, the xml:lang element is valid. See http://www.ws-i.org/Profiles/BasicProfile-1.1.html#SOAP_Fault_Language

[gregturn]

Oleksandr Alesinskyy commented

O dare to disagree - official definition of SOAP schema is here http://schemas.xmlsoap.org/soap/envelope/ (as stated at http://www.w3.org/TR/2000/NOTE-SOAP-20000508/#_Toc478383507) and it does not contain lang attribute for faultstring element.

I can only guess why WS-I provided non-compliant profile, likely due to many violations "in the field", but I doubt that it has right to change definitions of W3C.

Anyway, it is a valid reason to not change defaults, but not valid reason to blantantly decline providing of some kind of "global switch" between strict (W3C) and relaxed (WS-I) compliance.

I would say that client better follow WS-I but servers (with unlimited circle of clients, as in our case) should follows more strict restrictions of W3C.

[gregturn]

Arjen Poutsma commented

Ok, we will take a look at this for 1.5.7.

[gregturn]

Arjen Poutsma commented

I've added the langAttributeOnSoap11FaulString property to both the SaajSoapMessageFactory, and AxiomSoapMessageFactory, which defaults to true. If set to false, the xml:lang attribute will not be added to SOAP 1.1 faults.

[gregturn]

Arjen Poutsma commented

Closing old issues