WebServiceTemplate still creates a connection even if a ClientInterceptor sets a Response [SWS-440]

[gregturn]

Hans-Peter Störr opened SWS-440 and commented

Problem: When a response is set on the messagecontext by a ClientInterceptor.handleRequest, an actual connection to the webservice is still created and the Webservice is actually accessed in hasError or hasFault. I would expect that the WebServiceTemplate would not even create a connection in this case.

Background: I tried to write a ClientInterceptor for the WebServiceTemplate that simulates an actual webservice call during a selftest of the system. ClientInterceptor.hasRequest checks whether this is during a selftest and sets the response on the MessageContext and the other system should never be contacted at all.

Possible Solutions:

• As a quick fix one could extend the first if(messageContext.hasResponse() ) in WebServiceTemplate.doSendAndReceive(MessageContext, ...) to the hasError check, since this check does not make much sense if the response was not sent, does it? 8-)

• Even if this quick fix is done, MessageContext.createConnection is still called, which does not seem appropriate to me. Perhaps this should be done only later, after the interceptors have been called?

---

Affects: 1.5.4

Issue Links:

• Provide xml based Mock for Web Services [SWS-263] #365 Provide xml based Mock for Web Services

1 votes, 0 watchers

[gregturn]

Arjen Poutsma commented

#365 seems related to what you're trying to do.

That said, the connection should not be opened. I will fix.

[gregturn]

Arjen Poutsma commented

I tried fixing this without breaking backwards compatibility and also make sure that all the various other transports and callbacks kept working, but couldn't. So I am resolving this as Won't Fix, unfortunately.

Overall, taking the route of a Mock Transport (#365) for doing integration tests on web services would have my preference for the scenario you describe.

[gregturn]

Arjen Poutsma commented

Closing old issues