Skip to content

Fix broken image links in ref docs. #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mconner opened this issue Feb 1, 2023 · 5 comments
Closed

Fix broken image links in ref docs. #1328

mconner opened this issue Feb 1, 2023 · 5 comments
Assignees
Labels
type: bug A general bug type: documentation A documentation update
Milestone

Comments

@mconner
Copy link

mconner commented Feb 1, 2023

what-is-spring-ws.adoc, under Runtime Environment, there's supposed to be an image for
/spring-projects/spring-ws/raw/main/src/main/asciidoctor/spring-deps.png
It looks like this is supposed to be:
/spring-projects/spring-ws/raw/main/src/main/asciidoctor/images/spring-deps.png

Also, even when this is corrected, when viewed in dark mode (switch at top of doc), the arrows in the diagram are not visible..

@gregturn gregturn changed the title Broken Image Link in what-is-spring-ws.adoc Fix broken image links in ref docs. Feb 1, 2023
@gregturn gregturn self-assigned this Feb 1, 2023
@gregturn gregturn added this to the 4.0.2 milestone Feb 1, 2023
@gregturn gregturn added type: documentation A documentation update type: bug A general bug labels Feb 1, 2023
@gregturn
Copy link
Contributor

gregturn commented Feb 1, 2023

Confirmed @mconner!

I also verified that inserting "images/" in front of it fixes the issue. Also, turns out this isn't the only image directive.

@mconner
Copy link
Author

mconner commented Feb 1, 2023

That was fast!
However, this will not fix the dark-mode issue, correct?

gregturn added a commit that referenced this issue Feb 1, 2023
@gregturn
Copy link
Contributor

gregturn commented Feb 1, 2023

No. I'm not quite sure what to do on that front.

@gregturn
Copy link
Contributor

gregturn commented Feb 1, 2023

Perhaps open a separate ticket to track that.

@mconner
Copy link
Author

mconner commented Feb 1, 2023

No. I'm not quite sure what to do on that front.

The issue appears to be that the image has a transparent background, Maybe add some css to make it white, since the image(s) is(are) assuming that, anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants