-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Provide Session Id Generation Strategy #2251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
spring-session-core/src/main/java/org/springframework/session/SessionIdGenerator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright 2014-2023 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.session; | ||
|
||
import java.util.UUID; | ||
|
||
/** | ||
* <p> | ||
* Id generator for creating new session. | ||
* </p> | ||
* | ||
* @author Yanming Zhou | ||
*/ | ||
@FunctionalInterface | ||
public interface SessionIdGenerator { | ||
|
||
/** | ||
* Using random UUID as default id generator. | ||
*/ | ||
SessionIdGenerator DEFAULT = () -> UUID.randomUUID().toString(); | ||
|
||
/** | ||
* Generate and return a new session identifier. | ||
* @return the newly generated session id | ||
*/ | ||
String generateId(); | ||
|
||
} |
51 changes: 51 additions & 0 deletions
51
spring-session-core/src/test/java/org/springframework/session/SessionIdGeneratorTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright 2014-2023 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.session; | ||
|
||
import java.util.concurrent.atomic.AtomicLong; | ||
|
||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* @author Yanming Zhou | ||
*/ | ||
class SessionIdGeneratorTests { | ||
|
||
static final String prefix = "sessionid-"; | ||
|
||
@Test | ||
void sessionIdShouldStartsWithCustomizedPrefix() { | ||
MapSession session = new MapSession(); | ||
assertThat(session.getId()).startsWith(prefix); | ||
session.changeSessionId(); | ||
assertThat(session.getId()).startsWith(prefix); | ||
} | ||
|
||
public static class MySessionIdGenerator implements SessionIdGenerator { | ||
|
||
private final AtomicLong counter = new AtomicLong(); | ||
|
||
@Override | ||
public String generateId() { | ||
return prefix + this.counter.incrementAndGet(); | ||
} | ||
|
||
} | ||
|
||
} |
1 change: 1 addition & 0 deletions
1
...-core/src/test/resources/META-INF/services/org.springframework.session.SessionIdGenerator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
org.springframework.session.SessionIdGeneratorTests$MySessionIdGenerator |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static
is not good ideaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then what's your suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At present, this PR can solve the problem easily.
I think
static
is structural problem (not this PR), I prefer PR #1547, using spring DI is better than SPI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That huge changeset is risky, this one is simple and reliable.