Skip to content

Conversation

qavid
Copy link
Contributor

@qavid qavid commented Jul 20, 2020

AuthenticationConverterServerWebExchangeMatcher is ServerWebExchangeMatcher implementation based on AuthenticationConverter which matches if ServerWebExchange can be converted to Authentication.
It can be used as a matcher where SecurityFilterChain should be matched based on used authentication method.
BearerTokenServerWebExchangeMatcher was replaced by this matcher.

Closes gh-8824

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 20, 2020
@jzheaux jzheaux self-assigned this Jul 20, 2020
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 20, 2020
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @qavid! I've left some feedback inline.

AuthenticationConverterServerWebExchangeMatcher is ServerWebExchangeMatcher implementation based on AuthenticationConverter which matches if ServerWebExchange can be converted to Authentication.
It can be used as a matcher where SecurityFilterChain should be matched based on used authentication method.
BearerTokenServerWebExchangeMatcher was replaced by this matcher.

Closes gh-8824
@qavid qavid requested a review from jzheaux July 20, 2020 22:16
@jzheaux jzheaux merged commit 37aa5f9 into spring-projects:master Jul 21, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Jul 21, 2020

Thanks, @qavid! This is now merged into master.

@qavid qavid deleted the gh-8824 branch July 21, 2020 16:31
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Aug 5, 2020
@jzheaux jzheaux added this to the 5.4.0-RC1 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making BearerTokenServerWebExchangeMatcher public and more generic
3 participants