Single-key Key Selector #7055
Merged
Single-key Key Selector #7055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
added
in: oauth2
rwinch
approved these changes
Jun 28, 2019
| * @author Josh Cummings | ||
| * @since 5.2 | ||
| */ | ||
| final class SingleKeyJWSKeySelector<C extends SecurityContext> implements JWSKeySelector<C> { |
There was a problem hiding this comment.
Should we consider submitting this to Nimbus?
There was a problem hiding this comment.
Thanks for checking on this. Yes, I'm planning on it.
There was a problem hiding this comment.
jgrandja
requested changes
Jun 28, 2019
| JWSKeySelector<SecurityContext> jwsKeySelector = | ||
| new JWSVerificationKeySelector<>(this.jwsAlgorithm, jwkSource); | ||
| new SingleKeyJWSKeySelector<>(this.jwsAlgorithm, this.secretKey); |
There was a problem hiding this comment.
I don't think this should have changed since it's the SecretKey builder and the issue raised is for PublicKey.
There was a problem hiding this comment.
Makes sense, I've raised #7056 so that this gets articulated.
| private final List<Key> keySet; | ||
| private final JWSAlgorithm expectedJwsAlgorithm; | ||
|
|
||
| public SingleKeyJWSKeySelector(JWSAlgorithm expectedJwsAlgorithm, Key key) { |
There was a problem hiding this comment.
You can remove the public modifier since the class is package-private
jgrandja
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: gh-7049