Skip to content

Add custom parameters to token introspection requests #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

Add custom parameters to token introspection requests #6870

merged 1 commit into from
May 14, 2019

Conversation

@sayembd
Copy link
Contributor

@sayembd sayembd commented May 13, 2019

Added support for providing custom parameters to an OAuth 2.0 token introspection request. This is done by explicitly instantiating a NimbusOAuth2TokenIntrospectionClient instance and then setting a custom Converter implementation.

@sayembd sayembd mentioned this pull request May 13, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 13, 2019
jzheaux
jzheaux requested changes May 13, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @sayembd! I've left some feedback inline.

@jzheaux jzheaux removed the status: waiting-for-triage An issue we've not yet triaged label May 13, 2019
@jzheaux jzheaux added this to the 5.2.x milestone May 13, 2019
@jzheaux jzheaux self-assigned this May 13, 2019
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement labels May 13, 2019
@sayembd
Add custom parameters to token introspection requests
7e570ae 
Added support for providing custom parameters to an OAuth 2.0 token
introspection request. This is done by explicitly instantiating a
NimbusOAuth2TokenIntrospectionClient instance and then setting a custom
Converter implementation.

Fixes spring-projectsgh-6798
@sayembd
Copy link
Contributor Author

sayembd commented May 14, 2019

Thanks for the review, @jzheaux, I have made the necessary changes.

@jzheaux jzheaux merged commit 0bc60dc into spring-projects:master May 14, 2019
@jzheaux
Copy link
Contributor

jzheaux commented May 14, 2019 •
edited
Loading

Thanks, @sayembd! This is now merged into master. I also did a quick polish via 5840e25

@sayembd sayembd deleted the gh-6798 branch May 14, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels

in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Milestone

5.2.x

Development

Successfully merging this pull request may close these issues.

3 participants

@sayembd @jzheaux @spring-projects-issues