-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Introduce @CurrentSecurityContext for method arguments #6562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
core/src/main/java/org/springframework/security/core/annotation/CurrentSecurityContext.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
* Copyright 2002-2019 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.springframework.security.core.annotation; | ||
|
||
import java.lang.annotation.Documented; | ||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
/** | ||
* Annotation that is used to resolve {@link SecurityContext#getAuthentication()} to a method | ||
* argument. | ||
* | ||
* @author Dan Zheng | ||
* @since 5.2 | ||
* | ||
* See: <a href= | ||
* "{@docRoot}/org/springframework/security/web/bind/support/CurrentSecurityContextArgumentResolver.html" | ||
* > CurrentSecurityContextArgumentResolver </a> | ||
*/ | ||
@Target({ ElementType.PARAMETER }) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Documented | ||
public @interface CurrentSecurityContext { | ||
/** | ||
* True if a {@link ClassCastException} should be thrown when the current | ||
* {@link SecurityContext} is the incorrect type. Default is false. | ||
* | ||
* @return | ||
*/ | ||
boolean errorOnInvalidType() default false; | ||
|
||
/** | ||
* If specified will use the provided SpEL expression to resolve the security context. This | ||
* is convenient if users need to transform the result. | ||
* | ||
* <pre> | ||
* @CurrentSecurityContext(expression = "authentication") Authentication authentication | ||
* </pre> | ||
* | ||
* <p> | ||
* if you want to retrieve more object from the authentcation, you can see the following the expression | ||
* </p> | ||
* | ||
* <pre> | ||
* @CurrentSecurityContext(expression = "authentication.principal") Object principal | ||
* </pre> | ||
* | ||
* @return the expression to use. | ||
*/ | ||
String expression() default ""; | ||
} |
172 changes: 172 additions & 0 deletions
172
...org/springframework/security/web/bind/support/CurrentSecurityContextArgumentResolver.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,172 @@ | ||
/* | ||
* Copyright 2002-2019 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.springframework.security.web.bind.support; | ||
|
||
import java.lang.annotation.Annotation; | ||
|
||
import org.springframework.core.MethodParameter; | ||
import org.springframework.core.annotation.AnnotationUtils; | ||
import org.springframework.expression.BeanResolver; | ||
import org.springframework.expression.Expression; | ||
import org.springframework.expression.ExpressionParser; | ||
import org.springframework.expression.spel.standard.SpelExpressionParser; | ||
import org.springframework.expression.spel.support.StandardEvaluationContext; | ||
import org.springframework.security.core.annotation.CurrentSecurityContext; | ||
import org.springframework.security.core.context.SecurityContext; | ||
import org.springframework.security.core.context.SecurityContextHolder; | ||
import org.springframework.stereotype.Controller; | ||
import org.springframework.util.StringUtils; | ||
import org.springframework.web.bind.support.WebDataBinderFactory; | ||
import org.springframework.web.context.request.NativeWebRequest; | ||
import org.springframework.web.method.support.HandlerMethodArgumentResolver; | ||
import org.springframework.web.method.support.ModelAndViewContainer; | ||
|
||
/** | ||
* Allows resolving the {@link SecurityContext} using the | ||
* {@link CurrentSecurityContext} annotation. For example, the following | ||
* {@link Controller}: | ||
* | ||
* <pre> | ||
* @Controller | ||
* public class MyController { | ||
* @RequestMapping("/im") | ||
* public void security(@CurrentSecurityContext SecurityContext context) { | ||
* // do something with context | ||
* } | ||
* } | ||
* </pre> | ||
* | ||
* it can also support the spring SPEL expression to get the value from SecurityContext | ||
* <pre> | ||
* @Controller | ||
* public class MyController { | ||
* @RequestMapping("/im") | ||
* public void security(@CurrentSecurityContext(expression="authentication") Authentication authentication) { | ||
* // do something with context | ||
* } | ||
* } | ||
* </pre> | ||
* | ||
* <p> | ||
* Will resolve the SecurityContext argument using {@link SecurityContextHolder#getContext()} from | ||
* the {@link SecurityContextHolder}. If the {@link SecurityContext} is null, it will return null. | ||
* If the types do not match, null will be returned unless | ||
* {@link CurrentSecurityContext#errorOnInvalidType()} is true in which case a | ||
* {@link ClassCastException} will be thrown. | ||
* </p> | ||
* | ||
* @author Dan Zheng | ||
* @since 5.2 | ||
*/ | ||
public final class CurrentSecurityContextArgumentResolver | ||
implements HandlerMethodArgumentResolver { | ||
|
||
private ExpressionParser parser = new SpelExpressionParser(); | ||
|
||
private BeanResolver beanResolver; | ||
/** | ||
* check if this argument resolve can support the parameter. | ||
* @param parameter the method parameter. | ||
* @return true = it can support parameter. | ||
* | ||
* @see | ||
* org.springframework.web.method.support.HandlerMethodArgumentResolver# | ||
* supportsParameter(org.springframework.core.MethodParameter) | ||
*/ | ||
public boolean supportsParameter(MethodParameter parameter) { | ||
return findMethodAnnotation(CurrentSecurityContext.class, parameter) != null; | ||
} | ||
|
||
/** | ||
* resolve the argument to inject into the controller parameter. | ||
* @param parameter the method parameter. | ||
* @param mavContainer the model and view container. | ||
* @param webRequest the web request. | ||
* @param binderFactory the web data binder factory. | ||
* | ||
* @see org.springframework.web.method.support.HandlerMethodArgumentResolver# | ||
* resolveArgument (org.springframework.core.MethodParameter, | ||
* org.springframework.web.method.support.ModelAndViewContainer, | ||
* org.springframework.web.context.request.NativeWebRequest, | ||
* org.springframework.web.bind.support.WebDataBinderFactory) | ||
*/ | ||
public Object resolveArgument(MethodParameter parameter, | ||
ModelAndViewContainer mavContainer, NativeWebRequest webRequest, | ||
WebDataBinderFactory binderFactory) throws Exception { | ||
SecurityContext securityContext = SecurityContextHolder.getContext(); | ||
if (securityContext == null) { | ||
return null; | ||
} | ||
Object securityContextResult = securityContext; | ||
|
||
CurrentSecurityContext securityContextAnnotation = findMethodAnnotation( | ||
CurrentSecurityContext.class, parameter); | ||
|
||
String expressionToParse = securityContextAnnotation.expression(); | ||
if (StringUtils.hasLength(expressionToParse)) { | ||
StandardEvaluationContext context = new StandardEvaluationContext(); | ||
context.setRootObject(securityContext); | ||
context.setVariable("this", securityContext); | ||
|
||
Expression expression = this.parser.parseExpression(expressionToParse); | ||
securityContextResult = expression.getValue(context); | ||
} | ||
|
||
if (securityContextResult != null | ||
&& !parameter.getParameterType().isAssignableFrom(securityContextResult.getClass())) { | ||
if (securityContextAnnotation.errorOnInvalidType()) { | ||
throw new ClassCastException(securityContextResult + " is not assignable to " | ||
+ parameter.getParameterType()); | ||
} | ||
else { | ||
return null; | ||
} | ||
} | ||
return securityContextResult; | ||
} | ||
/** | ||
* Sets the {@link BeanResolver} to be used on the expressions | ||
* @param beanResolver the {@link BeanResolver} to use | ||
*/ | ||
public void setBeanResolver(BeanResolver beanResolver) { | ||
this.beanResolver = beanResolver; | ||
clevertension marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
/** | ||
* Obtains the specified {@link Annotation} on the specified {@link MethodParameter}. | ||
* | ||
* @param annotationClass the class of the {@link Annotation} to find on the | ||
* {@link MethodParameter} | ||
* @param parameter the {@link MethodParameter} to search for an {@link Annotation} | ||
* @return the {@link Annotation} that was found or null. | ||
*/ | ||
private <T extends Annotation> T findMethodAnnotation(Class<T> annotationClass, | ||
MethodParameter parameter) { | ||
T annotation = parameter.getParameterAnnotation(annotationClass); | ||
if (annotation != null) { | ||
return annotation; | ||
} | ||
Annotation[] annotationsToSearch = parameter.getParameterAnnotations(); | ||
for (Annotation toSearch : annotationsToSearch) { | ||
annotation = AnnotationUtils.findAnnotation(toSearch.annotationType(), | ||
annotationClass); | ||
if (annotation != null) { | ||
return annotation; | ||
} | ||
} | ||
return null; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.