Add Bearer Token filter to Security Filters #5524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
commented
Jul 16, 2018
| @@ -2721,6 +2721,7 @@ | |||
| <xs:enumeration value="LOGIN_PAGE_FILTER"/> | |||
| <xs:enumeration value="LOGOUT_PAGE_FILTER"/> | |||
| <xs:enumeration value="DIGEST_AUTH_FILTER"/> | |||
| <xs:enumeration value="BEARER_TOKEN_AUTH_FILTER"/> | |||
There was a problem hiding this comment.
Is this something that we should wait on until #5480?
EDIT It appears that this change is necessary. XsdDocumentedTests requires that the xsd match the contents of SecurityFilters.
There was a problem hiding this comment.
@jzheaux I'm not sure if the xsd or rnc file should have been changed? I never did update these for oauth2-client filters given that xml support is not there yet. Also, when I do a local build one of these files is changed which never happened before this commit. I believe it's the xsd file that get's generated.
@rwinch Is this change necessary?
This introduces BearerTokenAuthenticationFilter to SecurityFilters so that it can be used in the various addFilter methods and with the `custom-filter` xml tag. Fixes: spring-projectsgh-5479
rwinch
added
in: config
|
Thanks for the PR @jzheaux! It is now merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces BearerTokenAuthenticationFilter to SecurityFilters so
that it can be used in the various addFilter methods and with the
custom-filter xml tag.
Fixes: gh-5479