Skip to content

Build failures on Windows Machine due to line feed character #9727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcusdacoregio opened this issue May 6, 2021 · 0 comments
Closed

Build failures on Windows Machine due to line feed character #9727

marcusdacoregio opened this issue May 6, 2021 · 0 comments
Assignees
@marcusdacoregio
Labels
in: build An issue in the build type: bug A general bug

Comments

@marcusdacoregio
Copy link
Contributor

Describe the bug
When running the command ./gradlew clean build on the project, you should face some errors with the checkFormat tasks, asking for you to run ./gradlew format.
Once you run the format command, it replaces all the line endings with the Windows default line feed character. Making a change in the entire codebase

To Reproduce
Set the core.autocrlf property from git to false (git config --global core.autocrlf false) and clone the repository. Run ./gradlew clean build.

Expected behavior
The project should be build with SUCCESS
@marcusdacoregio marcusdacoregio added in: build An issue in the build type: bug A general bug labels May 6, 2021
@marcusdacoregio marcusdacoregio self-assigned this May 6, 2021
@marcusdacoregio marcusdacoregio mentioned this issue May 7, 2021
Closed
@marcusdacoregio marcusdacoregio linked a pull request May 7, 2021 that will close this issue
Fix Build Errors on Windows #9726
Closed
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue May 7, 2021
@marcusdacoregio
Normalize line endings to LF
c12c330 
Closes spring-projectsgh-9727
jzheaux pushed a commit that referenced this issue May 12, 2021
@marcusdacoregio @jzheaux
Add New Job to Verify Windows Build on CI Workflow
d3f5521 
Issue gh-9727
jzheaux added a commit that referenced this issue May 12, 2021
@jzheaux
Add Additional Binary Exceptions
02474fd 
Issue gh-9727
marcusdacoregio pushed a commit to marcusdacoregio/spring-security that referenced this issue May 13, 2021
@jzheaux @marcusdacoregio
Add Additional Binary Exceptions
1cb2c3a 
Issue spring-projectsgh-9727
@marcusdacoregio marcusdacoregio mentioned this issue May 14, 2021
Merged
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue May 14, 2021
@marcusdacoregio
Update Check Windows CI Workflow
54f977b 
- Add slack integration for error reporting
- Rename from check_windows to build_windows
- Change the build command to match the one in build_jdk_11
- Add build_windows to the needs of deployment and failure check jobs

Issue spring-projectsgh-9727
marcusdacoregio added a commit that referenced this issue May 14, 2021
@marcusdacoregio
Update Check Windows CI Workflow
8b839f7 
- Add slack integration for error reporting
- Rename from check_windows to build_windows
- Change the build command to match the one in build_jdk_11
- Add build_windows to the needs of deployment and failure check jobs

Issue gh-9727
jzheaux pushed a commit that referenced this issue May 14, 2021
@marcusdacoregio @jzheaux
Update Check Windows CI Workflow
85fb9c0 
- Add slack integration for error reporting
- Rename from check_windows to build_windows
- Change the build command to match the one in build_jdk_11
- Add build_windows to the needs of deployment and failure check jobs

Issue gh-9727
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Add New Job to Verify Windows Build on CI Workflow
48c88e6 
Issue spring-projectsgh-9727
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Add .gitattributes
ad453b5 
Normalize line endings to auto
Ensure that some file extensions are treated as binary

Closes spring-projectsgh-9727
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@jzheaux
Add Additional Binary Exceptions
35275e4 
Issue spring-projectsgh-9727
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Update Check Windows CI Workflow
81cf64d 
- Add slack integration for error reporting
- Rename from check_windows to build_windows
- Change the build command to match the one in build_jdk_11
- Add build_windows to the needs of deployment and failure check jobs

Issue spring-projectsgh-9727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: build An issue in the build type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Build Errors on Windows marcusdacoregio/spring-security
1 participant
@marcusdacoregio