-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Closed
Labels
in: webAn issue in web modules (web, webmvc)An issue in web modules (web, webmvc)status: first-timers-onlyAn issue that can only be worked on by brand new contributorsAn issue that can only be worked on by brand new contributorstype: enhancementA general enhancementA general enhancement
Milestone
Description
BasicAuthenticationFilter
checks that the Authorization
header starts with the "basic" scheme:
if (header == null || !header.toLowerCase().startsWith("basic ")) {
However, this is not as efficient as it could be, since it needs to lowercase the entire header just to compare the first few characters.
org.springframework.util.StringUtils#startsWithIgnoreCase
is nice for situations like these:
if (!StringUtils.startsWithIgnoreCase("basic ")) {
It would be great to do the same for the WebFlux counterpart, ServerHttpBasicAuthenticationConverter
.
rwinch
Metadata
Metadata
Assignees
Labels
in: webAn issue in web modules (web, webmvc)An issue in web modules (web, webmvc)status: first-timers-onlyAn issue that can only be worked on by brand new contributorsAn issue that can only be worked on by brand new contributorstype: enhancementA general enhancementA general enhancement