Skip to content

ClientRegistration Support baseUrl in template #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Sep 29, 2017 · 3 comments
Closed

ClientRegistration Support baseUrl in template #4589

rwinch opened this issue Sep 29, 2017 · 3 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.0.0.M5

Comments

@rwinch
Copy link
Member

rwinch commented Sep 29, 2017

Summary

Instead of needing to type {scheme}://{serverName}:{serverPort}{contextPath} we should also support {baseUrl} (or some similar variable name) that composes all of those values. This should be in addition to the existing variables.
@rwinch rwinch added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Sep 29, 2017
@rwinch rwinch added this to the 5.0.0.M5 milestone Sep 29, 2017
@rwinch
Copy link
Member Author

rwinch commented Sep 29, 2017

Just setting a Milestone. Can push if necessary

@jgrandja jgrandja mentioned this issue Sep 29, 2017
Closed
28 tasks
@jgrandja
Copy link
Contributor

jgrandja commented Oct 2, 2017

I'll set the new uri variable name to be {baseRedirectUrl}

@jgrandja jgrandja reopened this Oct 2, 2017
@jgrandja
Copy link
Contributor

jgrandja commented Oct 2, 2017

We may want to re-consider renaming from baseRedirectUrl to baseUrl

@rwinch rwinch modified the milestones: 5.0.0.M5, 5.0.0.RC1 Oct 3, 2017
@jgrandja jgrandja modified the milestones: 5.0.0.RC1, 5.0.0.M5 Oct 6, 2017
thomasdarimont pushed a commit to thomasdarimont/spring-security that referenced this issue Apr 25, 2018
@jgrandja @thomasdarimont
redirect-uri property supports 'baseRedirectUrl' uri variable
0e3984b 
Fixes spring-projectsgh-4589
thomasdarimont pushed a commit to thomasdarimont/spring-security that referenced this issue Apr 25, 2018
@jgrandja @thomasdarimont
ClientRegistration supports 'baseUrl' uri variable
aef6dbd 
Fixes spring-projectsgh-4589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.0.0.M5
Development

No branches or pull requests
2 participants
@rwinch @jgrandja