Polish JsonContentHandler.isEmptyCollection() #535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @izeye. This was intentional when I wrote it as I thought it made the intent clearer. Your proposal's made me doubt myself now though. I'm not sure the current code is any clearer and it's more verbose. |
@wilkinsona When I saw the code, I felt the same thing but on the other hand also felt like a duplicate of the following flow. I don't have a strong opinion on this and am okay with either way. |
wilkinsona
added a commit
that referenced
this pull request
Aug 1, 2018
* gh-535: Polish JsonContentHandler.isEmptyCollection()
|
Thanks again, @izeye. The proposed change is now in 1.2.x and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes
JsonContentHandler.isEmptyCollection()by removing a removable flow.