Quote cols attribute in Asciidoctor examples #482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the [oficial asciidoctor.org reference for tables](/https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#tables) seems a bit ambiguous and does not use quotes for the `cols` attribute all the time, it seems that quotes are required for the example of `[cols="1,3"]`in Lin 139 My setup: spring-restdocs 2.0.0.RELEASE, Gradle plugin `"org.asciidoctor.convert" version "1.5.3`, Spring Boot 2.0.0.RC1, Java 9, Ubuntu
wilkinsona
added a commit
that referenced
this pull request
Feb 19, 2018
* gh-482: Quote cols attribute in Asciidoc table example
|
Thanks very much for making your first contribution to REST Docs. I've merged the change into 1.2.x and forwards into master. |
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the oficial asciidoctor.org reference for tables seems a bit ambiguous and does not use quotes for the
colsattribute all the time, it seems that quotes are required for the example of[cols="1,3"]in Line 139My setup:
spring-restdocs 2.0.0.RELEASE, Gradle plugin
"org.asciidoctor.convert" version "1.5.3, Spring Boot 2.0.0.RC1, Java 9, Ubuntu