Use SpringBoot dependencies for version constraints #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Sep 29, 2022
| */ | ||
| @SpringBootTest(classes = SpringPulsarBootTestApp.class) | ||
| @SpringBootTest(classes = SpringPulsarBootTestApp.class, | ||
| properties = { "spring.main.banner-mode=off" |
There was a problem hiding this comment.
The SB banner is logged very early, before the test log config file is respected apparently and it always was showing up in the output. This was the only test that was happening in and it is gone now.
At this point the only thing we see in test output is WARN,ERROR logs.
sobychacko
approved these changes
Sep 29, 2022
onobc
force-pushed
the
cbono-slim-java-platform
branch
from
8acd007 to
b04615d
Compare
This reduces the dependency constraints specified in the spring-pulsar-dependencies java-platform. All removed dependencies are covered by the SB BOM and were using the same exact version as the BOM. This does not force SB on Spring Pulsar users as it is an internal project detail only.
onobc
force-pushed
the
cbono-slim-java-platform
branch
from
b04615d to
0783cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main item
This PR replaces the many manual entries in the
spring-pulsar-dependenciesGradle Java Platform.All removed dependencies are covered by the SB BOM and were previously using the same exact version as in the SB BOM. We had to manually keep these in sync and it was toil.
@sobychacko This does not force SB on Spring Pulsar users as it is an internal project detail only.
Piggyback commit
Further reduces the test logging output