Skip to content

LdapTemplate should close stream with null results #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 67 commits into from
Closed

LdapTemplate should close stream with null results #1170

wants to merge 67 commits into from

Conversation

prthakre
Copy link

jzheaux and others added 30 commits June 16, 2025 14:11
@jzheaux
Prepare for 4.0 Development
b6b4158
@jzheaux
Remove LDAP + Data Source Transaction Wrappers
32a866f 
Closes spring-projectsgh-1109
@jzheaux
Update to Spring Framework 7
d1a7944 
Closes spring-projectsgh-1110
@jzheaux
Use DefaultConversionService
a2bc78b 
This commit changes DefaultObjectDirectoryMapper to use
DefaultConversionService, preserving standard converters
that were there previous to deprecating ConverterManager.

Closes spring-projectsgh-1101
@jzheaux
Remove Unused Files
56f5854 
Issue spring-projectsgh-1109
@jzheaux
Update Dependabot for 4.x
9d0c616
@jzheaux
Update to Gradle 8.14.2
19205f4 
Closes spring-projectsgh-1111
@dependabot @jzheaux
Bump io.spring.javaformat:spring-javaformat-gradle-plugin
cdc05aa 
Bumps [io.spring.javaformat:spring-javaformat-gradle-plugin](https://github.com/spring-io/spring-javaformat) from 0.0.44 to 0.0.46.
- [Release notes](https://github.com/spring-io/spring-javaformat/releases)
- [Commits](spring-io/spring-javaformat@v0.0.44...v0.0.46)

---
updated-dependencies:
- dependency-name: io.spring.javaformat:spring-javaformat-gradle-plugin
  dependency-version: 0.0.46
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump io.spring.develocity.conventions from 0.0.22 to 0.0.23
c349601 
Bumps [io.spring.develocity.conventions](https://github.com/spring-io/develocity-conventions) from 0.0.22 to 0.0.23.
- [Release notes](https://github.com/spring-io/develocity-conventions/releases)
- [Commits](spring-io/develocity-conventions@v0.0.22...v0.0.23)

---
updated-dependencies:
- dependency-name: io.spring.develocity.conventions
  dependency-version: 0.0.23
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump io.micrometer:micrometer-bom from 1.14.7 to 1.14.8
001750c 
Bumps [io.micrometer:micrometer-bom](https://github.com/micrometer-metrics/micrometer) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/micrometer-metrics/micrometer/releases)
- [Commits](micrometer-metrics/micrometer@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: io.micrometer:micrometer-bom
  dependency-version: 1.14.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.springframework.security:spring-security-bom
0635672 
Bumps [org.springframework.security:spring-security-bom](https://github.com/spring-projects/spring-security) from 6.4.5 to 6.4.6.
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](spring-projects/spring-security@6.4.5...6.4.6)

---
updated-dependencies:
- dependency-name: org.springframework.security:spring-security-bom
  dependency-version: 6.4.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump io.micrometer:micrometer-tracing-bom from 1.4.6 to 1.4.7
cb88ed8 
Bumps [io.micrometer:micrometer-tracing-bom](https://github.com/micrometer-metrics/tracing) from 1.4.6 to 1.4.7.
- [Release notes](https://github.com/micrometer-metrics/tracing/releases)
- [Commits](micrometer-metrics/tracing@v1.4.6...v1.4.7)

---
updated-dependencies:
- dependency-name: io.micrometer:micrometer-tracing-bom
  dependency-version: 1.4.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump com.fasterxml.jackson:jackson-bom from 2.18.4 to 2.19.1
2cab480 
Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.18.4 to 2.19.1.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.18.4...jackson-bom-2.19.1)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-version: 2.19.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@jzheaux @lkb85
Fix Comment Typos
14e63a5 
See spring-projectsgh-998

Co-Authored-By: kibeom lee <[email protected]>
@dependabot @jzheaux
Bump org.slf4j:log4j-over-slf4j from 1.7.36 to 2.0.17
b5908ce 
Bumps org.slf4j:log4j-over-slf4j from 1.7.36 to 2.0.17.

---
updated-dependencies:
- dependency-name: org.slf4j:log4j-over-slf4j
  dependency-version: 2.0.17
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump com.apollographql.apollo from 2.5.14 to 4.3.1
77ef652 
Bumps com.apollographql.apollo from 2.5.14 to 4.3.1.

---
updated-dependencies:
- dependency-name: com.apollographql.apollo
  dependency-version: 4.3.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump io.micrometer:micrometer-tracing-bom from 1.4.6 to 1.5.2
8734656 
---
updated-dependencies:
- dependency-name: io.micrometer:micrometer-tracing-bom
  dependency-version: 1.5.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@jzheaux
Update Core Tests to JUnit 5
3d4f74a 
Issue spring-projectsgh-1058
@jzheaux
Update Ldif Tests to JUnit 5
9cb2ba6 
Issue spring-projectsgh-1058
@jzheaux
Update Odm Tests to JUnit 5
e69a0ab 
Issue spring-projectsgh-1058
@jzheaux
Update Sandbox Tests to JUnit 5
4e72a91 
Issue spring-projectsgh-1058
@dependabot @jzheaux
Bump io.spring.javaformat:spring-javaformat-gradle-plugin
bd85ac3 
Bumps [io.spring.javaformat:spring-javaformat-gradle-plugin](https://github.com/spring-io/spring-javaformat) from 0.0.46 to 0.0.47.
- [Release notes](https://github.com/spring-io/spring-javaformat/releases)
- [Commits](spring-io/spring-javaformat@v0.0.46...v0.0.47)

---
updated-dependencies:
- dependency-name: io.spring.javaformat:spring-javaformat-gradle-plugin
  dependency-version: 0.0.47
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump com.squareup.okhttp3:mockwebserver from 3.14.9 to 5.1.0
177dba3 
Bumps [com.squareup.okhttp3:mockwebserver](https://github.com/square/okhttp) from 3.14.9 to 5.1.0.
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-3.14.9...parent-5.1.0)

---
updated-dependencies:
- dependency-name: com.squareup.okhttp3:mockwebserver
  dependency-version: 5.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.mockito:mockito-core from 3.12.4 to 5.18.0
d8b4580 
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 3.12.4 to 5.18.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.12.4...v5.18.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-version: 5.18.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump io.micrometer:micrometer-bom from 1.14.8 to 1.15.2
9e23748 
Bumps [io.micrometer:micrometer-bom](https://github.com/micrometer-metrics/micrometer) from 1.14.8 to 1.15.2.
- [Release notes](https://github.com/micrometer-metrics/micrometer/releases)
- [Commits](micrometer-metrics/micrometer@v1.14.8...v1.15.2)

---
updated-dependencies:
- dependency-name: io.micrometer:micrometer-bom
  dependency-version: 1.15.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump com.apollographql.apollo:apollo-runtime from 2.5.14 to 4.3.1
0d8060a 
Bumps [com.apollographql.apollo:apollo-runtime](https://github.com/apollographql/apollo-kotlin) from 2.5.14 to 4.3.1.
- [Release notes](https://github.com/apollographql/apollo-kotlin/releases)
- [Changelog](https://github.com/apollographql/apollo-kotlin/blob/main/CHANGELOG.md)
- [Commits](apollographql/apollo-kotlin@v2.5.14...v4.3.1)

---
updated-dependencies:
- dependency-name: com.apollographql.apollo:apollo-runtime
  dependency-version: 4.3.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.mockito:mockito-junit-jupiter from 3.12.4 to 5.18.0
a733479 
Bumps [org.mockito:mockito-junit-jupiter](https://github.com/mockito/mockito) from 3.12.4 to 5.18.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.12.4...v5.18.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-junit-jupiter
  dependency-version: 5.18.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jzheaux
Increase PR Limit to Ten Per Branch
aeccadb
@dependabot @jzheaux
Bump org.sonarsource.scanner.gradle:sonarqube-gradle-plugin
d91fdea 
Bumps [org.sonarsource.scanner.gradle:sonarqube-gradle-plugin](https://github.com/SonarSource/sonar-scanner-gradle) from 2.8.0.1969 to 6.2.0.5505.
- [Release notes](https://github.com/SonarSource/sonar-scanner-gradle/releases)
- [Commits](SonarSource/sonar-scanner-gradle@2.8.0.1969...6.2.0.5505)

---
updated-dependencies:
- dependency-name: org.sonarsource.scanner.gradle:sonarqube-gradle-plugin
  dependency-version: 6.2.0.5505
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.springframework.data:spring-data-bom from 2021.2.18 to 2025.0.1
0a297aa 
Bumps [org.springframework.data:spring-data-bom](https://github.com/spring-projects/spring-data-bom) from 2021.2.18 to 2025.0.1.
- [Release notes](https://github.com/spring-projects/spring-data-bom/releases)
- [Commits](spring-projects/spring-data-bom@2021.2.18...2025.0.1)

---
updated-dependencies:
- dependency-name: org.springframework.data:spring-data-bom
  dependency-version: 2025.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jzheaux jzheaux added this to the 3.3.3 milestone Jul 30, 2025
@jzheaux jzheaux changed the title PR 1169 LdapTemplate should close stream with null results Jul 30, 2025
@jzheaux jzheaux mentioned this pull request Jul 30, 2025
Closed
@prthakre
Copy link
Author

Sure, please check.

jzheaux and others added 16 commits August 7, 2025 12:19
@jzheaux
Update Copyright Headers to Use 2006-present
0358363 
Closes spring-projectsgh-1173
@jzheaux
Revert "Remove 3.2.x from CI"
6485641 
Support for 3.2.x as been extended to align with the
Boot 3.4 support window

This reverts commit 3053f27.
@jzheaux
Rename License File
fb082d3
@jzheaux
Apply License File to Each Jar
30a8735 
Closes spring-projectsgh-1176
@jzheaux
Update Copyright Headers for XML and Groovy Files
5f2cf1e 
Issue spring-projectsgh-1173
@etrandafir93 @jzheaux
Migrate test-support to JUnit 5
d48508f 
Issue spring-projectsgh-1058

Signed-off-by: etrandafir93 <[email protected]>
@dependabot @jzheaux
Bump io.spring.gradle:spring-security-release-plugin
5a5965a 
Bumps [io.spring.gradle:spring-security-release-plugin](https://github.com/spring-io/spring-security-release-tools) from 1.0.6 to 1.0.10.
- [Release notes](https://github.com/spring-io/spring-security-release-tools/releases)
- [Commits](spring-io/spring-security-release-tools@v1.0.6...v1.0.10)

---
updated-dependencies:
- dependency-name: io.spring.gradle:spring-security-release-plugin
  dependency-version: 1.0.10
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.junit:junit-bom from 5.13.3 to 5.13.4
40396bd 
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit-framework) from 5.13.3 to 5.13.4.
- [Release notes](https://github.com/junit-team/junit-framework/releases)
- [Commits](junit-team/junit-framework@r5.13.3...r5.13.4)

---
updated-dependencies:
- dependency-name: org.junit:junit-bom
  dependency-version: 5.13.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.gretty:gretty from 4.1.6 to 4.1.7
514d656 
Bumps [org.gretty:gretty](https://github.com/gretty-gradle-plugin/gretty) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/gretty-gradle-plugin/gretty/releases)
- [Changelog](https://github.com/gretty-gradle-plugin/gretty/blob/master/changes.md)
- [Commits](gretty-gradle-plugin/gretty@v4.1.6...v4.1.7)

---
updated-dependencies:
- dependency-name: org.gretty:gretty
  dependency-version: 4.1.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.springframework.security:spring-security-bom
e5d7669 
Bumps [org.springframework.security:spring-security-bom](https://github.com/spring-projects/spring-security) from 6.5.1 to 6.5.2.
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](spring-projects/spring-security@6.5.1...6.5.2)

---
updated-dependencies:
- dependency-name: org.springframework.security:spring-security-bom
  dependency-version: 6.5.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump commons-codec:commons-codec from 1.18.0 to 1.19.0
ba8f60d 
Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.18.0 to 1.19.0.
- [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt)
- [Commits](apache/commons-codec@rel/commons-codec-1.18.0...rel/commons-codec-1.19.0)

---
updated-dependencies:
- dependency-name: commons-codec:commons-codec
  dependency-version: 1.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump org.springframework.data:spring-data-bom from 2025.0.1 to 2025.0.2
2ce6b79 
Bumps [org.springframework.data:spring-data-bom](https://github.com/spring-projects/spring-data-bom) from 2025.0.1 to 2025.0.2.
- [Release notes](https://github.com/spring-projects/spring-data-bom/releases)
- [Commits](spring-projects/spring-data-bom@2025.0.1...2025.0.2)

---
updated-dependencies:
- dependency-name: org.springframework.data:spring-data-bom
  dependency-version: 2025.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @jzheaux
Bump com.fasterxml.jackson:jackson-bom from 2.19.1 to 2.19.2
468f397 
Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.19.1 to 2.19.2.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.19.1...jackson-bom-2.19.2)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-version: 2.19.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions
Release 4.0.0-M2
d91398f
@github-actions
Next development version
64da193
@dependabot @jzheaux
Bump actions/checkout from 4 to 5
4d62b6a 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jzheaux
Copy link
Collaborator

jzheaux commented Aug 14, 2025

Hi, @prthakre. DCO gives the following error:

"Prashant [email protected]", but got "Prashant Thakre [email protected]".

Are you able to update your commit so that the signature matches the commit owner? Note that I rebased your branch with the latest 3.3.x, so you may need to reset locally to update the commit signature.

@dependabot @jzheaux
Bump org.jfrog.buildinfo:build-info-extractor-gradle
2f66328 
Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin) from 4.34.1 to 6.0.0.
- [Release notes](https://github.com/jfrog/artifactory-gradle-plugin/releases)
- [Commits](https://github.com/jfrog/artifactory-gradle-plugin/commits/6.0.0)

---
updated-dependencies:
- dependency-name: org.jfrog.buildinfo:build-info-extractor-gradle
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jzheaux jzheaux modified the milestones: 3.3.3, 3.3.x Aug 14, 2025
@prthakre prthakre closed this Aug 15, 2025
@prthakre prthakre deleted the PR_1169 branch August 15, 2025 17:30
@prthakre
Copy link
Author

@jzheaux I have raised a new PR: #1196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: core status: waiting-for-feedback We need additional information before we can continue type: bug A general bug
Projects
None yet
Milestone
3.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@prthakre @jzheaux @etrandafir93