Skip to content

GH-95: Fix @TopicPartition Array Resolution #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

GH-95: Fix @TopicPartition Array Resolution #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/java/org/springframework/kafka/annotation/KafkaListenerAnnotationBeanPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ private void resolvePartitionAsInteger(String topic, Object resolvedValue,
resolvePartitionAsInteger(topic, object, result);
}
}
if (resolvedValue instanceof String) {
else if (resolvedValue instanceof String) {
Assert.state(StringUtils.hasText((String) resolvedValue),
"partition in @TopicPartition for topic '" + topic + "' cannot be empty");
result.add(new org.apache.kafka.common.TopicPartition(topic, Integer.valueOf((String) resolvedValue)));
Expand Down
4 changes: 3 additions & 1 deletion ...kafka/src/test/java/org/springframework/kafka/annotation/EnableKafkaIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,9 @@ public void listen4(@Payload String foo, Acknowledgment ack) {
}

@KafkaListener(id = "fiz", topicPartitions = {
@TopicPartition(topic = "annotated5", partitions = { "0", "1" }),
@TopicPartition(topic = "annotated5",
partitions = {
"#{T(org.springframework.util.StringUtils).commaDelimitedListToStringArray('${foo:0,1}')}" }),
@TopicPartition(topic = "annotated6", partitions = { "0", "1" })
})
public void listen5(ConsumerRecord<?, ?> record) {
Expand Down