Skip to content

GH-522: Fix NPE in listener container #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2017
Merged

GH-522: Fix NPE in listener container #524

merged 2 commits into from
Dec 18, 2017

Conversation

garyrussell
Copy link
Contributor

Fixes #522

artembilan
artembilan reviewed Dec 18, 2017
View reviewed changes
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
return Collections.unmodifiableCollection(listenerConsumer.assignedPartitions);
}
else {
return null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to fix toString() as well.
Right now it might finish with the ", topicPartitions=null", which might not be so useful.

Your thoughts?

Thanks

@artembilan artembilan merged commit 7d1aa4e into spring-projects:master Dec 18, 2017
artembilan pushed a commit that referenced this pull request Dec 18, 2017
@garyrussell @artembilan
GH-522: Fix NPE in listener container (#524)
6d45eb0 
Fixes #522

* Polishing - PR Comment

**Cherry-pick to 2.0.x & 1.3.x**
artembilan pushed a commit that referenced this pull request Dec 18, 2017
@garyrussell @artembilan
GH-522: Fix NPE in listener container (#524)
ad4e4cf 
Fixes #522

* Polishing - PR Comment

**Cherry-pick to 2.0.x & 1.3.x**
@artembilan
Copy link
Member

... and cherry-picked to 2.0.x and 1.3.x

@ghost
Copy link

ghost commented Dec 19, 2017

Hi, many thanks ... I still can not believe, that it happens so fast :)

@ghost
Copy link

ghost commented Jan 17, 2018

Hi, which will be the spring-kafka-2.0.x version with the fix?

Thanks

@garyrussell
Copy link
Contributor Author

It will be in 2.0.3; we can release that this week.

Is there some reason you can't upgrade to 2.1.1, which includes the fix?

@garyrussell garyrussell deleted the GH-522 branch January 17, 2018 14:36
@ghost
Copy link

ghost commented Jan 18, 2018 •
edited by ghost
Loading

Hi,
we will first update / fix to the smaller version and on the next release iteration to the next version 2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyrussell @artembilan