Upgrade to Kafka 4.1.0 and update API usage #4072
Conversation
sobychacko
added
the
type: dependency-upgrade
spring-kafka/src/test/java/org/springframework/kafka/core/DefaultShareConsumerFactoryTests.java
Show resolved
Hide resolved
...rc/test/java/org/springframework/kafka/support/serializer/SerializationIntegrationTests.java
Show resolved
Hide resolved
|
BTW, I don't see any changes in the |
- Bump kafkaVersion from 4.0.0 to 4.1.0 in build.gradle
- Remove broker properties no longer needed in embedded Kafka tests:
* unstable.api.versions.enable=true
* group.coordinator.rebalance.protocols=classic,share
- Replace AcknowledgeType.ACCEPT with commitSync() in share consumer tests
- Remove explicit acknowledge() calls in implicit mode tests since 4.1.0 client disallowed that
- Leverage implicit acknowledgment where records are automatically treated as ACCEPT
- Use commitSync() for explicit commit timing instead of relying on next poll() auto-commit
- Maintains same test semantics while following Kafka 4.1 implicit mode best practices
- Update SerializationIntegrationTests to use Plugin-based deserializer access
- Update SerializationIntegrationTests to use Plugin-based deserializer access in 4.1.0 client
- Replace direct deserializer access with plugin mechanism retrieval
- Use KafkaTestUtils.getPropertyValue() to access valueDeserializerPlugin from consumer internals
- Verify plugin returns expected delegating deserializer instance
Signed-off-by: Soby Chacko <[email protected]>
|
@artembilan, It came down to the fact that in 4.1.0, they introduced an implicit/explicit mode of ack (or changed the semantics of it). In the implicit mode (the default one), you are not allowed to explicitly call In the serializer test, they removed the deserializer field in preference to a plugin mechanism. I will update the commit message and the comments. Thanks! |
sobychacko
force-pushed
the
kafka-4.1.0-upgrade
branch
from
42de3ff to
27f17c2
Compare
Bump kafkaVersion from 4.0.0 to 4.1.0 in build.gradle
Remove broker properties no longer needed in embedded Kafka tests:
Replace AcknowledgeType.ACCEPT with commitSync() in share consumer tests
Update SerializationIntegrationTests to use Plugin-based deserializer access