GH-3740: Fix HandlerAdapter to detect Kotlin suspend functions
#3742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions Fixes: spring-projects#3740 Issue link: spring-projects#3740 Even if Kotlin `suspend` functions are called properly, the acknowledgement is not called because this kind of method is not treated as an `asyncReplies` mode * Fix `HandlerAdapter` to check for `KotlinDetector.isSuspendingFunction()` in addition to `CompletableFuture` & `Mono` * Adjust `EnableKafkaKotlinCoroutinesTests.kt` to verify that `acknowledgement` has been called by the Framework **Auto-cherry-pick to `3.3.x` & `3.2.x`**
sobychacko
approved these changes
Feb 13, 2025
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3740
Issue link: #3740
Even if Kotlin
suspendfunctions are called properly, the acknowledgement is not called because this kind of method is not treated as anasyncRepliesmodeHandlerAdapterto check forKotlinDetector.isSuspendingFunction()in addition toCompletableFuture&MonoEnableKafkaKotlinCoroutinesTests.ktto verify thatacknowledgementhas been called by the FrameworkAuto-cherry-pick to
3.3.x&3.2.x